Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9643 )
Change subject: java: key ConnectionCache by address, improve stringification ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9643/2/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java: http://gerrit.cloudera.org:8080/#/c/9643/2/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java@52 PS2, Line 52: Preconditions.checkArgument(hostPort.getPort() > 0); Add Preconditions.checkNotNull(hostPort); ? -- To view, visit http://gerrit.cloudera.org:8080/9643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431b5b6b8af6b81e6ab494d7f84fa2260bb0f941 Gerrit-Change-Number: 9643 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 04:11:54 +0000 Gerrit-HasComments: Yes
