Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9676 )
Change subject: KUDU-1447. Automatically disable THP on process heap ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9676/1/src/kudu/util/process_memory.cc File src/kudu/util/process_memory.cc: http://gerrit.cloudera.org:8080/#/c/9676/1/src/kudu/util/process_memory.cc@244 PS1, Line 244: if (FLAGS_disable_hugepages == "auto") { consider using boost::iequals here and below if you want to be a bit more lenient. http://gerrit.cloudera.org:8080/#/c/9676/1/src/kudu/util/process_memory.cc@284 PS1, Line 284: << reinterpret_cast<void*>(min_addr) << "-" Consider using 'addr_range' directly instead of reconstructing it with casts. http://gerrit.cloudera.org:8080/#/c/9676/1/src/kudu/util/process_memory.cc@417 PS1, Line 417: extern "C" void* end; add a comment? Not clear what this is for. -- To view, visit http://gerrit.cloudera.org:8080/9676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e356466f0473546d52763123e7948f2e8756ceb Gerrit-Change-Number: 9676 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 15 Mar 2018 23:53:53 +0000 Gerrit-HasComments: Yes
