Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9676 )
Change subject: KUDU-1447. Automatically disable THP on process heap ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9676/1/src/kudu/util/process_memory.cc File src/kudu/util/process_memory.cc: http://gerrit.cloudera.org:8080/#/c/9676/1/src/kudu/util/process_memory.cc@284 PS1, Line 284: // "012b7000-012d8000 rw-p 00000000 00:00 0 [heap]" > Worth noting that addr_range has a format without '0x', so using 'addr_rang yes, I also don't think it's critical to have the 0x prefix. These errors should (hopefully) be rare enough that I think having the original source before parsing would be useful, if only to rule out parse issues. -- To view, visit http://gerrit.cloudera.org:8080/9676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e356466f0473546d52763123e7948f2e8756ceb Gerrit-Change-Number: 9676 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 00:44:58 +0000 Gerrit-HasComments: Yes
