Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/9676 )
Change subject: KUDU-1447. Automatically disable THP on process heap ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9676/2/src/kudu/util/process_memory.cc File src/kudu/util/process_memory.cc: http://gerrit.cloudera.org:8080/#/c/9676/2/src/kudu/util/process_memory.cc@246 PS2, Line 246: VLOG(1) << "Based on running kernel, will " > Done (here for the auto case). Do you think we should do it even when expli I wanna say that just here is fine, OTOH principle of least astonishment would make me want it all the time. -- To view, visit http://gerrit.cloudera.org:8080/9676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e356466f0473546d52763123e7948f2e8756ceb Gerrit-Change-Number: 9676 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 16 Mar 2018 00:45:51 +0000 Gerrit-HasComments: Yes
