Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9676 )
Change subject: KUDU-1447. Automatically disable THP on process heap ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9676/3/src/kudu/kserver/kserver.cc File src/kudu/kserver/kserver.cc: http://gerrit.cloudera.org:8080/#/c/9676/3/src/kudu/kserver/kserver.cc@119 PS3, Line 119: Impala Nit: let's keep this a little more abstract (i.e. "since other projects may share ServerBase...". http://gerrit.cloudera.org:8080/#/c/9676/3/src/kudu/util/process_memory.cc File src/kudu/util/process_memory.cc: http://gerrit.cloudera.org:8080/#/c/9676/3/src/kudu/util/process_memory.cc@28 PS3, Line 28: #include <boost/algorithm/string/predicate.hpp> // IWYU pragma: keep Why did you need a pragma for this? IWYU doesn't recognize that you're using something out of predicate.hpp? http://gerrit.cloudera.org:8080/#/c/9676/3/src/kudu/util/process_memory.cc@158 PS3, Line 158: ,google::RegisterFlagValidator(&FLAGS_disable_hugepages, &ValidateDisableHugePagesFlag) Tasty. -- To view, visit http://gerrit.cloudera.org:8080/9676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e356466f0473546d52763123e7948f2e8756ceb Gerrit-Change-Number: 9676 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 15:57:24 +0000 Gerrit-HasComments: Yes
