Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/inbound_call.h File src/kudu/rpc/inbound_call.h: http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/inbound_call.h@253 PS3, Line 253: int64_t I wonder if this should also be int32_t to match the equivalent in OutboundCall ? http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/inbound_call.cc File src/kudu/rpc/inbound_call.cc: http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/inbound_call.cc@225 PS3, Line 225: outbound_sidecars_total_bytes_ += sidecar_bytes; If you end up converting outbound_sidecars_total_bytes_ to int32_t as suggested elsewhere, you may wanna DCHECK_GE(outbound_sidecrs_total_bytes_, 0) here. http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/outbound_call.h File src/kudu/rpc/outbound_call.h: http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/outbound_call.h@276 PS3, Line 276: // Total size in bytes of all sidecars in 'sidecars_'. Set in SetRequestPayload(). Add a comment that this should not exceed TransferLimits::kMaxTotalSidecarBytes http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/rpc_controller.h File src/kudu/rpc/rpc_controller.h: http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/rpc_controller.h@275 PS3, Line 275: int64_t Again, we seem a bit inconsistent on whether this should be 32-bit or 64-bit. -- To view, visit http://gerrit.cloudera.org:8080/9601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d041e214b15d9c22b810588643798e2b3bc5c24 Gerrit-Change-Number: 9601 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 22:44:58 +0000 Gerrit-HasComments: Yes
