Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/9601/3/src/kudu/rpc/rpc-test.cc@724 PS3, Line 724: s.resize(TransferLimits::kMaxTotalSidecarBytes, 'a'); > I will look into what test could exist. The awkward thing is that maxing ou I'm afraid about fixing hypotehtical issues with a non-hypothetical test. How do we know we fixed it? Aren't we getting some false confidence, then, if we haven't proven it? What about making the flag an int64 but adding a validator that it can't be set more than 2GB or whatever you think is a reasonable max for Impala? In the tests, then, by setting the flag variable manually you can override the validator. Also, shouldn't the maximum match up between the client side and server? What you said above is a bit concerning - why is the client sending a message that the server will reject? -- To view, visit http://gerrit.cloudera.org:8080/9601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d041e214b15d9c22b810588643798e2b3bc5c24 Gerrit-Change-Number: 9601 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 21:43:00 +0000 Gerrit-HasComments: Yes
