Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/9601/7/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/9601/7/src/kudu/rpc/rpc-test.cc@724 PS7, Line 724: CHECK this can be an ASSERT_FALSE http://gerrit.cloudera.org:8080/#/c/9601/7/src/kudu/rpc/rpc-test.cc@761 PS7, Line 761: CHECK_OK this can be ASSERT_OK right? http://gerrit.cloudera.org:8080/#/c/9601/7/src/kudu/rpc/rpc-test.cc@783 PS7, Line 783: // Reset rpc_max_message_size to its default value This is done automatically by our base test class using google::FlagSaver so not necessary here http://gerrit.cloudera.org:8080/#/c/9601/7/src/kudu/rpc/rpc_sidecar.cc File src/kudu/rpc/rpc_sidecar.cc: http://gerrit.cloudera.org:8080/#/c/9601/7/src/kudu/rpc/rpc_sidecar.cc@80 PS7, Line 80: %d this should be $1 -- To view, visit http://gerrit.cloudera.org:8080/9601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d041e214b15d9c22b810588643798e2b3bc5c24 Gerrit-Change-Number: 9601 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 23:52:52 +0000 Gerrit-HasComments: Yes
