Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt@816 PS1, Line 816: pipe-delimited Why not just use the original semi-colon delimiters? Or why not comma-delimited or colon-delimited, either of which have some prior art? http://gerrit.cloudera.org:8080/#/c/9772/1/src/kudu/tablet/CMakeLists.txt File src/kudu/tablet/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9772/1/src/kudu/tablet/CMakeLists.txt@91 PS1, Line 91: ADD_KUDU_TEST(compaction_policy-test DATA_FILES ycsb-test-rowsets.tsv) > The real change is adding the data file here and removing the 'ln -sf' stuf The real change was the friends we made along the way. -- To view, visit http://gerrit.cloudera.org:8080/9772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6 Gerrit-Change-Number: 9772 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 22 Mar 2018 23:52:23 +0000 Gerrit-HasComments: Yes
