Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt@816 PS1, Line 816: pipe-delimited > I tried using the original delimiters, but the problem is that the environm I don't feel strongly, but I just think it's more typical to see colon delimiting (Java classpath) or comma delimiting (most other applications) rather than pipe delimiting, and on the off chance that someone peeks at a /proc/dist-test/environ, it'll surprise them less. -- To view, visit http://gerrit.cloudera.org:8080/9772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6 Gerrit-Change-Number: 9772 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 23 Mar 2018 00:02:12 +0000 Gerrit-HasComments: Yes
