Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt@816 PS1, Line 816: pipe-delimited > Why not just use the original semi-colon delimiters? Or why not comma-delim I tried using the original delimiters, but the problem is that the environment is passed to ctest using a semicolon-delimited list of key=value pairs, so putting a semicolon in the environment variable breaks it... As for using a colon, that would be fine too. I was afraid if I did that you'd complain that it hampers portability on Windows since it won't support C:\ paths :) But if you like it better, happy to change. -- To view, visit http://gerrit.cloudera.org:8080/9772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6 Gerrit-Change-Number: 9772 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 22 Mar 2018 23:57:11 +0000 Gerrit-HasComments: Yes
