Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt@714 PS1, Line 714: # DATA_FILES <file1> <file2> ... you might note that the multi-arg nature of this is unused in this commit, but it's used in the next commit in this patch series and I figured it would be easier to review separately. http://gerrit.cloudera.org:8080/#/c/9772/1/src/kudu/tablet/CMakeLists.txt File src/kudu/tablet/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9772/1/src/kudu/tablet/CMakeLists.txt@91 PS1, Line 91: ADD_KUDU_TEST(compaction_policy-test DATA_FILES ycsb-test-rowsets.tsv) The real change is adding the data file here and removing the 'ln -sf' stuff. I re-sorted the tests because I knew Adar would ask me to if I didn't. -- To view, visit http://gerrit.cloudera.org:8080/9772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6 Gerrit-Change-Number: 9772 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 22 Mar 2018 23:37:32 +0000 Gerrit-HasComments: Yes
