Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 )
Change subject: Improve the C++ client sample ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9838/1/src/kudu/client/client_samples-test.sh File src/kudu/client/client_samples-test.sh: http://gerrit.cloudera.org:8080/#/c/9838/1/src/kudu/client/client_samples-test.sh@27 PS1, Line 27: [ -n "$TS_PID" ] Kind of nit, while you're updating syntax: the GSG bash edition mentions we should prefer using [[ instead of [ https://google.github.io/styleguide/shell.xml#Test,_%5B_and_%5B%5B Maybe it's fine as is, not sure we follow the GSGs for anything besides C++ -- To view, visit http://gerrit.cloudera.org:8080/9838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fcc9f46b5e28b18f1a96082fd61a1f3402f59ff Gerrit-Change-Number: 9838 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 28 Mar 2018 18:29:33 +0000 Gerrit-HasComments: Yes
