Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 )
Change subject: Improve the C++ client example ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/9838/1/samples/cpp/README.adoc File samples/cpp/README.adoc: http://gerrit.cloudera.org:8080/#/c/9838/1/samples/cpp/README.adoc@125 PS1, Line 125: your Kudu master servers > "your Kudu cluster" maybe? Done http://gerrit.cloudera.org:8080/#/c/9838/1/samples/cpp/sample.cc File samples/cpp/sample.cc: http://gerrit.cloudera.org:8080/#/c/9838/1/samples/cpp/sample.cc@103 PS1, Line 103: // Generate and add the split rows for the table. > Nit: not really split rows anymore. Done http://gerrit.cloudera.org:8080/#/c/9838/1/samples/cpp/sample.cc@110 PS1, Line 110: > Extra whitespace here? Done http://gerrit.cloudera.org:8080/#/c/9838/1/src/kudu/client/client_samples-test.sh File src/kudu/client/client_samples-test.sh: http://gerrit.cloudera.org:8080/#/c/9838/1/src/kudu/client/client_samples-test.sh@27 PS1, Line 27: [ -n "$TS_PID" ] > Yeah I think we only follow GSG for C++. But I'm not opposed to choosing a +1 to picking a bash codestyle. http://gerrit.cloudera.org:8080/#/c/9838/1/src/kudu/client/client_samples-test.sh@27 PS1, Line 27: [ -n "$TS_PID" ] > Kind of nit, while you're updating syntax: the GSG bash edition mentions we Done http://gerrit.cloudera.org:8080/#/c/9838/1/src/kudu/client/client_samples-test.sh@103 PS1, Line 103: $(getconf _NPROCESSORS_ONLN) > Nit: would nproc be easier here? Or will that not work on macOS? Seems it's necessary to do it that way for macOS. Comment added. -- To view, visit http://gerrit.cloudera.org:8080/9838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fcc9f46b5e28b18f1a96082fd61a1f3402f59ff Gerrit-Change-Number: 9838 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 28 Mar 2018 18:40:52 +0000 Gerrit-HasComments: Yes
