Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 )
Change subject: Improve the C++ client example ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9838/1/samples/cpp/sample.cc File samples/cpp/sample.cc: http://gerrit.cloudera.org:8080/#/c/9838/1/samples/cpp/sample.cc@297 PS1, Line 297: if (exists) { > Whoa there Tidy Bot. Everything is going to be ok. yea, clang doesn't do inter-translation-unit analysis, so it has no idea that there's a contract that pointer out-params are modified. It's too bad it doesn't take a more conservative stance and assume that they are. -- To view, visit http://gerrit.cloudera.org:8080/9838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fcc9f46b5e28b18f1a96082fd61a1f3402f59ff Gerrit-Change-Number: 9838 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 01:34:18 +0000 Gerrit-HasComments: Yes
