Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9838 )
Change subject: Improve the C++ client example ...................................................................... Improve the C++ client example This does some small things to improve the C++ client example: 1. I used shellcheck to find and fix some warnings with client_examples-test.sh. Mostly pedantic stuff. 2. I fixed a bug with the lsof command where it wasn't filtering lines, so it ran some bogus numeric comparisons on extra lines. Obviously this didn't break the script but it generated errors. 3. I added support for multimaster to the example script. I tested it manually but I didn't change client_examples-test.sh to use multimaster, since it seemed like it would just make it more complex and possibly more flaky without much payoff. 4. I fixed up the example code so it no longer uses any deprecated APIs. Specifically, I got rid of a use of 'split_rows' in the table creation step and the swapped in KuduScanBatch for vector<RowResult> in the scanner part. 5. I fixed up the wording and removed a duplicated section from the example's README. Change-Id: I7fcc9f46b5e28b18f1a96082fd61a1f3402f59ff Reviewed-on: http://gerrit.cloudera.org:8080/9838 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M examples/cpp/README.adoc M examples/cpp/example.cc M src/kudu/client/client_examples-test.sh M src/kudu/client/scan_batch.h 4 files changed, 149 insertions(+), 151 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified Andrew Wong: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/9838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7fcc9f46b5e28b18f1a96082fd61a1f3402f59ff Gerrit-Change-Number: 9838 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]>
