Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 )
Change subject: KUDU-2351 Add IP/port for Recv() failure ...................................................................... Patch Set 10: > Patch Set 10: > > > Patch Set 10: > > > > > Patch Set 10: > > > > > > Did you see my note about TlsSocket? It's fine if you don't want to take > > > that on in this same patch, but be aware that TlsSocket is probably the > > > more common case nowadays. > > > > Sorry, I missed that one somehow. I'll change it in TlsSocket as well then, > > I kind of assumed it wraps Socket. > > Actually, it extends Socket, so I think it should be fine. Or do you have a > specific error message I should look into? It does inherit from Socket, but it overrides Recv, so the error messages orginating there won't incude the IP address: https://github.com/apache/kudu/blob/master/src/kudu/security/tls_socket.cc#L105. I'm fine holding off on TLS socket if this isn't something that comes up in practice. -- To view, visit http://gerrit.cloudera.org:8080/9818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22436b13bb351b132e1c0b7159294dd0c980c2b3 Gerrit-Change-Number: 9818 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 06 Apr 2018 17:03:41 +0000 Gerrit-HasComments: No
