Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 )
Change subject: [spark]KUDU-2371: Add KuduWriteOptions class and ignoreNull option ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/9834/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/9834/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@247 PS4, Line 247: ignoring any new : * rows that have a primary key conflict with existing rows. > Please add a second bit to the docs here stating that insertIgnoreRows(df, don't you mean "wo.ignoreDuplicateRowErrors = true" above? http://gerrit.cloudera.org:8080/#/c/9834/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala: http://gerrit.cloudera.org:8080/#/c/9834/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala@20 PS4, Line 20: class KuduWriteOptions( if this is part of the public API shouldn't it have an interface audience and stability annotation? http://gerrit.cloudera.org:8080/#/c/9834/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala@21 PS4, Line 21: var ignoreDuplicateRowErrors: Boolean = false, if public, probably should have javadoc (or scaladoc? whatever the equivalent is in Scala) -- To view, visit http://gerrit.cloudera.org:8080/9834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide908ea29f572849eca0ba850ee197c1b22a07c8 Gerrit-Change-Number: 9834 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 05:33:19 +0000 Gerrit-HasComments: Yes
