Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9848 )
Change subject: KUDU-2378. Fix unaligned loads of int128 from rows ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9848/6/src/kudu/cfile/plain_block.h File src/kudu/cfile/plain_block.h: http://gerrit.cloudera.org:8080/#/c/9848/6/src/kudu/cfile/plain_block.h@27 PS6, Line 27: #include "kudu/util/coding-inl.h" > Oh I see. I expected the comment to be based on the changed line. Done http://gerrit.cloudera.org:8080/#/c/9848/1/src/kudu/gutil/port.h File src/kudu/gutil/port.h: http://gerrit.cloudera.org:8080/#/c/9848/1/src/kudu/gutil/port.h@1170 PS1, Line 1170: #if defined(__i386) || defined(ARCH_ATHLON) || defined(__x86_64__) || defined(_ARCH_PPC) > Do we actually care about ARCH_ATHLON and _ARCH_PPC? Or was this sourced fr I switched to using the #define that is already defined up above instead of repeating this set http://gerrit.cloudera.org:8080/#/c/9848/1/src/kudu/gutil/port.h@1187 PS1, Line 1187: typename port_internal::enable_if_numeric<T>::type* = nullptr, > What does this template parameter do? I don't see 'type' referenced in the this is magic enable_if. See http://en.cppreference.com/w/cpp/types/enable_if example #4 -- To view, visit http://gerrit.cloudera.org:8080/9848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic71149ed5c6881cb16dfe6cf8f7906c044a0b41a Gerrit-Change-Number: 9848 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 17 Apr 2018 05:29:45 +0000 Gerrit-HasComments: Yes
