Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10097/1/java/kudu-client-tools/build.gradle File java/kudu-client-tools/build.gradle: http://gerrit.cloudera.org:8080/#/c/10097/1/java/kudu-client-tools/build.gradle@31 PS1, Line 31: // TODO: This pulls a lot of dependencies into the shaded jar This is still an open item for this patch. Gradle includes all the transitive dependencies. I think that is the right thing to do but creates a larger shaded jar than maven. It also fails verify_jars.pl because of the extra classes. -- To view, visit http://gerrit.cloudera.org:8080/10097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e Gerrit-Change-Number: 10097 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 21 Apr 2018 14:39:30 +0000 Gerrit-HasComments: Yes
