Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts ...................................................................... Patch Set 5: (3 comments) Only got 1/2 way through this and need to go to meeting, but wanted to put up what I have. http://gerrit.cloudera.org:8080/#/c/10097/1/java/gradle.properties File java/gradle.properties: http://gerrit.cloudera.org:8080/#/c/10097/1/java/gradle.properties@25 PS1, Line 25: mavenUrl = https://repository.apache.org/service/local/staging/deploy/maven2 Why are scmUrl and issueTrackerUrl removed? http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties File java/gradle.properties: http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@25 PS5, Line 25: mavenUrl = https://repository.apache.org/service/local/staging/deploy/maven2 I think it'd be better to call this something like 'publishUrl' or 'mavenPublishUrl' to make it clear that this URL is being fed into publishing.gradle, and isn't used for any other kind of dependency resolution (where it wouldn't be appropriate to use a staging repo). http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@41 PS5, Line 41: signing.gnupg.executable = gpg Do we expect these properties to ever be modified? If not, it may be a bit more streamlined to put them in publishing.gradle to keep them close to where they are used. -- To view, visit http://gerrit.cloudera.org:8080/10097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e Gerrit-Change-Number: 10097 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Apr 2018 16:57:37 +0000 Gerrit-HasComments: Yes
