Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties File java/gradle.properties: http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@41 PS5, Line 41: # gpg-agent configuration for artifact signing. > If a user upgrades to gpg2 they may want to change these details. gpg2 is a SGTM http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle File java/gradle/publishing.gradle: http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle@39 PS7, Line 39: propertyWithDefault Are the username and password properties required? If so I think this shouldn't fallback to the empty string, because it will fail with a confusing error below about empty authentication creds. I imagine it will be easier to debug if you had a propert("mavenUsername") method which threw if it were undefined. http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle File java/kudu-spark/build.gradle: http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle@22 PS7, Line 22: compile(project(path: ":kudu-client", configuration: "shadow")) { Can you do the same trick you did in https://github.com/apache/kudu/commit/650e39e234142c69d4ff7adc56ad6359b790741b to only declare this exclusion once in build.gradle instead of every shaded jar? AFAICT you would want to do this wherever kudu-client is used in a shaded jar. -- To view, visit http://gerrit.cloudera.org:8080/10097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e Gerrit-Change-Number: 10097 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Apr 2018 21:17:48 +0000 Gerrit-HasComments: Yes
