Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/10097/1/java/gradle.properties File java/gradle.properties: http://gerrit.cloudera.org:8080/#/c/10097/1/java/gradle.properties@25 PS1, Line 25: mavenUrl = https://repository.apache.org/service/local/staging/deploy/maven2 > Why are scmUrl and issueTrackerUrl removed? They are not being used in the build so I didn't think it was worth keeping them. Some projects will add them to their generated poms, but I thought that had minimal value given we add the project url in the pom and that's likely where we would want users and contributors to go for information. http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties File java/gradle.properties: http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@25 PS5, Line 25: mavenUrl = https://repository.apache.org/service/local/staging/deploy/maven2 > I think it'd be better to call this something like 'publishUrl' or 'mavenPu Good idea. Will do. http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@41 PS5, Line 41: signing.gnupg.executable = gpg > Do we expect these properties to ever be modified? If not, it may be a bit If a user upgrades to gpg2 they may want to change these details. gpg2 is actually the default and these properties are set to use gpg as that's what our maven release process expected and seams more common. -- To view, visit http://gerrit.cloudera.org:8080/10097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e Gerrit-Change-Number: 10097 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Apr 2018 17:22:25 +0000 Gerrit-HasComments: Yes
