Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle File java/gradle/publishing.gradle: http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle@39 PS7, Line 39: propertyWithDefault > They are only required if the maven repository requires them. Below is the OK, I was thinking passing an empty string pair to authentication(..) would always be an issue. This is fine, if not. http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle File java/kudu-spark/build.gradle: http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle@22 PS7, Line 22: compile(project(path: ":kudu-client", configuration: "shadow")) { > I think I could globally exclude it from being shaded. I think that would be good, if possible. -- To view, visit http://gerrit.cloudera.org:8080/10097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e Gerrit-Change-Number: 10097 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Apr 2018 21:32:34 +0000 Gerrit-HasComments: Yes
