Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10288 )
Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: PS1: Just passing through, but maybe you could define the schema in protobuf, produce a PB object, then convert it to JSON using google::protobuf::util::MessageToJsonString? That'd make it easier to maintain the schema, and to reason about backwards compatibility when changing it. See ControlShellProtocol in tool_action_common.{h,cc} for inspiration. -- To view, visit http://gerrit.cloudera.org:8080/10288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5da0752f8e41c022611253c300450368f6ae969 Gerrit-Change-Number: 10288 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 02 May 2018 23:51:42 +0000 Gerrit-HasComments: Yes
