Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10288 )
Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck ...................................................................... Patch Set 1: (38 comments) http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@396 PS1, Line 396: ASSERT_OK((reader).ExtractObjectArray((value), (field), &array)); \ > warning: macro argument should be enclosed in parentheses [misc-macro-paren Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@397 PS1, Line 397: ASSERT_EQ(exp_size, array.size()); \ > warning: macro argument should be enclosed in parentheses [misc-macro-paren Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@502 PS1, Line 502: const string& key, > warning: parameter 'key' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@522 PS1, Line 522: const string key, > warning: the const qualified parameter 'key' is copied for each invocation; Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@550 PS1, Line 550: const vector<KsckTabletSummary> ref_tablets) { > warning: the const qualified parameter 'ref_tablets' is copied for each inv Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@964 PS1, Line 964: /*underreplicated_tables=*/ 0, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@965 PS1, Line 965: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@966 PS1, Line 966: /*unavailable_tables=*/ 0)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@997 PS1, Line 997: /*underreplicated_tables=*/ 0, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@998 PS1, Line 998: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@999 PS1, Line 999: /*unavailable_tables=*/ 1)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1030 PS1, Line 1030: /*underreplicated_tables=*/ 0, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1031 PS1, Line 1031: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1032 PS1, Line 1032: /*unavailable_tables=*/ 1)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1063 PS1, Line 1063: /*underreplicated_tables=*/ 0, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1064 PS1, Line 1064: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1065 PS1, Line 1065: /*unavailable_tables=*/ 1)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1085 PS1, Line 1085: /*underreplicated_tables=*/ 1, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1086 PS1, Line 1086: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1087 PS1, Line 1087: /*unavailable_tables=*/ 0)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1114 PS1, Line 1114: /*underreplicated_tables=*/ 1, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1115 PS1, Line 1115: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1116 PS1, Line 1116: /*unavailable_tables=*/ 0)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1149 PS1, Line 1149: /*underreplicated_tables=*/ 0, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1150 PS1, Line 1150: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1151 PS1, Line 1151: /*unavailable_tables=*/ 1)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1175 PS1, Line 1175: /*underreplicated_tables=*/ 0, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1176 PS1, Line 1176: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1177 PS1, Line 1177: /*unavailable_tables=*/ 0)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1200 PS1, Line 1200: /*underreplicated_tables=*/ 3, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1201 PS1, Line 1201: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1202 PS1, Line 1202: /*unavailable_tables=*/ 0)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1239 PS1, Line 1239: /*underreplicated_tables=*/ 3, > warning: argument name 'underreplicated_tables' in comment does not match p Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1240 PS1, Line 1240: /*consensus_mismatch_tables=*/ 0, > warning: argument name 'consensus_mismatch_tables' in comment does not matc Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck-test.cc@1241 PS1, Line 1241: /*unavailable_tables=*/ 0)); > warning: argument name 'unavailable_tables' in comment does not match param Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck_results.cc@35 PS1, Line 35: #include "kudu/tools/tool_action_common.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck_results.cc@40 PS1, Line 40: using std::cout; > warning: using decl 'cout' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck_results.cc@490 PS1, Line 490: w->Field("committed", cstate.type == KsckConsensusConfigType::PENDING ? false : true); > warning: redundant boolean literal in ternary expression result [readabilit Done -- To view, visit http://gerrit.cloudera.org:8080/10288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5da0752f8e41c022611253c300450368f6ae969 Gerrit-Change-Number: 10288 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 04 May 2018 19:44:40 +0000 Gerrit-HasComments: Yes
