Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10288 )
Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: PS1: > To be honest, while your points about schema and backwards compat are total I hear you. I'm sorry you didn't get this feedback earlier; I thought Todd was already providing guidance on this series, and in the past he's pushed to define JSON schemas via protobuf. If it's any consolation, it should reduce the amount of code in your patch substantially. -- To view, visit http://gerrit.cloudera.org:8080/10288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5da0752f8e41c022611253c300450368f6ae969 Gerrit-Change-Number: 10288 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 03 May 2018 00:27:38 +0000 Gerrit-HasComments: Yes
