Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10288 )
Change subject: [tools] ksck improvements [7/n] Add JSON output option to ksck ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10288/1/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: PS1: > Just passing through, but maybe you could define the schema in protobuf, pr To be honest, while your points about schema and backwards compat are totally valid, the idea of going back and rewriting all the tedious serialization code is totally deflating. Maybe if I ignore this patch for a week I'll feel like doing that :) -- To view, visit http://gerrit.cloudera.org:8080/10288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5da0752f8e41c022611253c300450368f6ae969 Gerrit-Change-Number: 10288 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 03 May 2018 00:15:40 +0000 Gerrit-HasComments: Yes
