Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 )
Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc@296 PS8, Line 296: ts->FetchInfo(&health).AndThen([&ts,&health]() { : if (FLAGS_consensus) { : return ts->FetchConsensusState(&h > Sound good. Mind adding it to the commit message as well? Done http://gerrit.cloudera.org:8080/#/c/10293/10/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/10293/10/src/kudu/tools/ksck_remote.cc@209 PS10, Line 209: *health = KsckServerHealth::UNAVAILABLE; > This never gets set to HEALTHY. I'm surprised that isn't caught somewhere b nice catch. I looked into it, the tests didn't catch it as ksck-test.cc uses a mock FetchConsensusState(KsckServerHealth* health) which always returns KsckServerHealth::OK and ksck_remote-test.cc doesn't check the whole consensus matrix, only checked for WRONG_SERVER_UUID and as FetchConsensusState is called only if FetchInfo returns OK. Now there's a new assertion in that fails RemoteKsckTest.TestTabletServerMismatchedUUID if FetchConsensusState(KsckServerHealth* health) returns UNAVAILABLE. -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 16 May 2018 16:57:35 +0000 Gerrit-HasComments: Yes
