Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 )
Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.h@284 PS11, Line 284: this class. 'health' must : // not be nullptr. Does it output anything with the 'health' out parameter? I think it's worth documenting that as well. BTW, why not to put the 'health' as a member of the class as well? http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.cc@298 PS11, Line 298: return ts->FetchConsensusState(&health); Why is it necessary to overwrite health status with FetchConsensusState()? Could it change since call of FetchInfo()? http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck_remote.cc@156 PS11, Line 156: CHECK(health) If you added this check for this method, maybe it's worth keeping the things consistent and add corresponding CHECK() into FetchConsensusState() as well? >From other side, it will crash anyway even without that check at line 158. >Maybe, it's worth dropping this check or converting it into DCHECK()? -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 16 May 2018 18:38:58 +0000 Gerrit-HasComments: Yes
