Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 )
Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.h@284 PS11, Line 284: this class. 'health' must : // not be nullptr. > Does it output anything with the 'health' out parameter? I think it's wort Documented it. Should it be a member of KsckTabletServer instead of an out parameter? http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck.cc@298 PS11, Line 298: return ts->FetchConsensusState(&health); > Why is it necessary to overwrite health status with FetchConsensusState()? It can't change between these two calls, but if FetchInfo() sets health to OK and FLAGS_consensus is true, then FetchConsensusState() can still set this to UNAVAILABLE if it returns a non-OK Status. Does this make sense? http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/10293/11/src/kudu/tools/ksck_remote.cc@156 PS11, Line 156: DCHECK(health > If you added this check for this method, maybe it's worth keeping the thing Done -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 12 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 16 May 2018 20:35:26 +0000 Gerrit-HasComments: Yes
