Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 )
Change subject: KUDU-2191: HMS Metadata Consistency Check Tool ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/kudu-tool-test.cc@1919 PS6, Line 1919: Status CreateLegacyHmsTable(HmsClient* client, > Might be more straightforward to split this into two methods, since there i Done http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc@271 PS6, Line 271: > Might be easier to make a copy of 'hive_table', then call PopulateTable wit Done http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc@293 PS6, Line 293: kudu_table > should this be 'unsynchronized tables:' Done http://gerrit.cloudera.org:8080/#/c/10217/6/src/kudu/tools/tool_action_hms.cc@348 PS6, Line 348: > remove period to be consistent Done -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 19 May 2018 00:55:39 +0000 Gerrit-HasComments: Yes
