Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 )
Change subject: KUDU-2191: HMS Metadata Consistency Check Tool ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc@394 PS10, Line 394: if (unsynced_tables_map.empty()) { > Hmm, right. L392 is logging a warning. You think it is not sufficient? Ah, I missed that. However I think this should also cause the tool to fail (return non-0 exist status), but perhaps not immediately if avoidable. Check out how ksck aggregates error messages. http://gerrit.cloudera.org:8080/#/c/10217/12/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/12/src/kudu/tools/tool_action_hms.cc@372 PS12, Line 372: "try to use metadata updrade tool first", add to the end the exact kudu tool invocation command http://gerrit.cloudera.org:8080/#/c/10217/12/src/kudu/tools/tool_action_hms.cc@372 PS12, Line 372: updrade upgrade http://gerrit.cloudera.org:8080/#/c/10217/12/src/kudu/tools/tool_action_hms.cc@404 PS12, Line 404: return Status::OK(); This failure should cause the tool to return a non-0 exit status. I imagine that requires returning a non-OK exist status, right? -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 22 Jun 2018 18:57:21 +0000 Gerrit-HasComments: Yes
