Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 )
Change subject: KUDU-2191: HMS Metadata Consistency Check Tool ...................................................................... Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/10217/11/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/10217/11/src/kudu/tools/kudu-tool-test.cc@2188 PS11, Line 2188: // 2. Create tables in Kudu and the HMS with inconsistent metadata. Then validate the tool > Should this cover the case of master address not matching? Done http://gerrit.cloudera.org:8080/#/c/10217/11/src/kudu/tools/kudu-tool-test.cc@2195 PS11, Line 2195: // but different table ID. > It's pretty difficult to see what each of the a/b/c/d/e tables are testing Done http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc@394 PS10, Line 394: if (unsynced_tables_map.empty()) { > I think it's still worth warning about legacy tables, otherwise the admin m Hmm, right. L392 is logging a warning. You think it is not sufficient? http://gerrit.cloudera.org:8080/#/c/10217/11/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/11/src/kudu/tools/tool_action_hms.cc@368 PS11, Line 368: } > Might be worth seeing if you can remove some of the nested if/else levels h Done http://gerrit.cloudera.org:8080/#/c/10217/11/src/kudu/tools/tool_action_hms.cc@396 PS11, Line 396: return Status::OK(); > Sorry my suggestion before on R10 was bad. This should be either Done -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 22 Jun 2018 01:29:29 +0000 Gerrit-HasComments: Yes
