Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 )
Change subject: KUDU-2191: HMS Metadata Consistency Check Tool ...................................................................... Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/10217/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10217/8//COMMIT_MSG@11 PS8, Line 11: colnum column http://gerrit.cloudera.org:8080/#/c/10217/8//COMMIT_MSG@12 PS8, Line 12: report reports http://gerrit.cloudera.org:8080/#/c/10217/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10217/10//COMMIT_MSG@11 PS10, Line 11: colnum column http://gerrit.cloudera.org:8080/#/c/10217/8/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/10217/8/src/kudu/tools/kudu-tool-test.cc@2177 PS8, Line 2177: schema http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc@130 PS10, Line 130: Status AlterLegacyKuduTables(const shared_ptr<KuduClient>& kudu_client, It's kind of confusing to pass a const ref to a mutable pointer, perhaps just pass KuduClient* and HmsCatalog* here and elsewhere. http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc@376 PS10, Line 376: RETURN_NOT_OK(kudu_client->OpenTable(table_name, &kudu_table)); Consider just doing an OpenTable instead of TableExists + OpenTable, and checking for the specific not exists error status. That way it's done atomically, and fewer master RPCs. http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc@394 PS10, Line 394: unsynced_tables_map[hms_table_id].emplace_back( Do legacy tables have a table ID param? http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc@399 PS10, Line 399: presented 'are not present' http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc@403 PS10, Line 403: unordered_map<string, hive::Table> hms_tables_map = RetrieveTablesMap(hms_tables); move hms_tables, if this is the last use of it. -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 18 Jun 2018 23:51:10 +0000 Gerrit-HasComments: Yes
