Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 )
Change subject: KUDU-2287 Expose election failures as metrics ...................................................................... Patch Set 18: (2 comments) > Patch Set 16: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/10076/15/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/10076/15/src/kudu/consensus/raft_consensus.cc@439 PS15, Line 439: active_role == RaftPeerPB::LEADER) { > I see, so it should be time_since_last_heartbeat_ instead of time_since_lea Done http://gerrit.cloudera.org:8080/#/c/10076/15/src/kudu/consensus/raft_consensus.cc@3003 PS15, Line 3003: } > I think it would be best to use a std::atomic<int64_t> for last_leader_comm Done -- To view, visit http://gerrit.cloudera.org:8080/10076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3 Gerrit-Change-Number: 10076 Gerrit-PatchSet: 18 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Sat, 26 May 2018 11:09:40 +0000 Gerrit-HasComments: Yes
