Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 )
Change subject: KUDU-2287 Expose election failures as metrics ...................................................................... Patch Set 22: (7 comments) http://gerrit.cloudera.org:8080/#/c/10076/21/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/10076/21/src/kudu/consensus/raft_consensus.cc@164 PS21, Line 164: This metric is identically zero on a lea > nit: It'd be possible to see 0 on a follower as well. Say instead, "This me Done http://gerrit.cloudera.org:8080/#/c/10076/21/src/kudu/consensus/raft_consensus.cc@911 PS21, Line 911: if (PREDICT_FALSE(VLOG_IS_ON(1))) { > I'd like to place this where the replica officially recognizes it has heard Done http://gerrit.cloudera.org:8080/#/c/10076/21/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: http://gerrit.cloudera.org:8080/#/c/10076/21/src/kudu/integration-tests/raft_consensus-itest.cc@2689 PS21, Line 2689: > nit: Here and below, comments should begin with a capital letter and end wi Done http://gerrit.cloudera.org:8080/#/c/10076/21/src/kudu/integration-tests/raft_consensus-itest.cc@2702 PS21, Line 2702: > This is reasonable, but it might make the test eventually flaky, say in TSA Done http://gerrit.cloudera.org:8080/#/c/10076/21/src/kudu/integration-tests/raft_consensus-itest.cc@2708 PS21, Line 2708: // difference between them is at least 500ms > Lower -heartbeat_interval_ms and elections will trigger faster, so this tes Done http://gerrit.cloudera.org:8080/#/c/10076/21/src/kudu/integration-tests/raft_consensus-itest.cc@2709 PS21, Line 2709: int64_t time_before_wait = GetTimeSinceLastLeaderHeartbeat(follower, tablet > Just in the interests of avoiding flakiness, let's ASSERT_EVENTUALLY on thi Done http://gerrit.cloudera.org:8080/#/c/10076/21/src/kudu/integration-tests/raft_consensus-itest.cc@2710 PS21, Line 2710: > It'd also be nice to restart the tservers and make sure (ASSERT_EVENTUALLY) checked, this whole thing runs at around 2300ms on my MacBook, while 1700ms without it, so I think this should stay without AllowSlowTests() -- To view, visit http://gerrit.cloudera.org:8080/10076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3 Gerrit-Change-Number: 10076 Gerrit-PatchSet: 22 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 16:43:09 +0000 Gerrit-HasComments: Yes
