Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 )
Change subject: KUDU-2287 Expose election failures as metrics ...................................................................... Patch Set 22: (4 comments) looking pretty good, just a few more comments http://gerrit.cloudera.org:8080/#/c/10076/22/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/10076/22/src/kudu/consensus/raft_consensus.h@871 PS22, Line 871: failed_elections_metric_ nit: rename to num_failed_elections_metric_ http://gerrit.cloudera.org:8080/#/c/10076/22/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/10076/22/src/kudu/consensus/raft_consensus.cc@1293 PS22, Line 1293: last_leader_communication_time_micros_ = GetMonoTimeMicros(); This should go down where we snooze the failure detector below line 1316, in case CheckLeaderRequestUnlocked() fails. http://gerrit.cloudera.org:8080/#/c/10076/22/src/kudu/consensus/raft_consensus.cc@2552 PS22, Line 2552: last_leader_communication_time_micros_ = 0; Put this inside BecomeLeaderUnlocked() http://gerrit.cloudera.org:8080/#/c/10076/22/src/kudu/consensus/raft_consensus.cc@3000 PS22, Line 3000: GetTimeSinceLastLeaderHeartbeat nit: rename this to GetMillisSinceLastLeaderHeartbeat() -- To view, visit http://gerrit.cloudera.org:8080/10076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3 Gerrit-Change-Number: 10076 Gerrit-PatchSet: 22 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 21:19:21 +0000 Gerrit-HasComments: Yes
