Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 )
Change subject: KUDU-2287 Expose election failures as metrics ...................................................................... Patch Set 20: > Patch Set 15: > > (1 comment) > > Also needs some tests, maybe in raft-consensus-itest, and possibly partially > as a new piece of existing tests. Probably also needs some tests specifically > for pre-election v election behavior. I added tests, I'm not sure a pre-election one is necessary at this point after refactoring the time-based metric to track time since leader heartbeat. I'm not quite sure what to do with failed_elections_since_stable_leader though, as this is still tracking pre-elections too. Should I remove this metric or is it fine like this or should I change it somehow? -- To view, visit http://gerrit.cloudera.org:8080/10076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3 Gerrit-Change-Number: 10076 Gerrit-PatchSet: 20 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 09:30:13 +0000 Gerrit-HasComments: No
