Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10546 )
Change subject: [Java] Add Schema.getColumnById ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10546/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: http://gerrit.cloudera.org:8080/#/c/10546/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java@234 PS1, Line 234: public ColumnSchema getColumnById(int columnId) { So the other methods dealing with column IDs have "This method is not part of the stable API" in their Javadoc. Seems like we should add that there. Although maybe we should be using annotations to denote the non-stable nature of column IDs? Separately, why is kudu-backup exposed to column IDs? Public clients typically refer to columns by name or by index; how did IDs surface? -- To view, visit http://gerrit.cloudera.org:8080/10546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee5c1abbe864b3e9f6905e0f70e9b708175071b0 Gerrit-Change-Number: 10546 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 18:26:16 +0000 Gerrit-HasComments: Yes
