Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10546 )
Change subject: [Java] Add Schema.getColumnById ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10546/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: http://gerrit.cloudera.org:8080/#/c/10546/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java@234 PS1, Line 234: public ColumnSchema getColumnById(int columnId) { > So the other methods dealing with column IDs have "This method is not part I didn't realize column ids weren't stable. I didn't see " * This method is not part of the stable API.' in the getColumnIndex method. Perhaps we should annotate the methods with InterfaceStability and InterfaceAudience methods. Column ids are exposed via KuduTable partition schemas (hash and range) here: https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java#L126 https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java#L146 Impala is also exposed to them in the same way and has a similar method: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/KuduTable.java#L313 Perhaps the better approach would be to support getting the column name or index from the PartitionSchemas? -- To view, visit http://gerrit.cloudera.org:8080/10546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee5c1abbe864b3e9f6905e0f70e9b708175071b0 Gerrit-Change-Number: 10546 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 18:51:00 +0000 Gerrit-HasComments: Yes
