Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10546 )
Change subject: [Java] Add Schema.getColumnById ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10546/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: http://gerrit.cloudera.org:8080/#/c/10546/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java@234 PS1, Line 234: public ColumnSchema getColumnById(int columnId) { Yeah our official stance has been to avoid exposing column IDs as part of the public API, but I'm not surprised we haven't been totally hygienic about it. It's quite possible that getColumnIndex predates our use of annotations, and it never got updated. I think we should tag both this new method and getColumnIndex as a non-public audience. > Perhaps the better approach would be to support getting the column name or > index from the PartitionSchemas? That sounds like a good idea. -- To view, visit http://gerrit.cloudera.org:8080/10546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee5c1abbe864b3e9f6905e0f70e9b708175071b0 Gerrit-Change-Number: 10546 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 21:21:09 +0000 Gerrit-HasComments: Yes
