Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10546 )
Change subject: [Java] Add Schema.getColumnById ...................................................................... Patch Set 1: This was a super small change to simplify getting the columns by there id. I assumed since it was easy, small and used by Impala too I would just add it to the client. It appears the id is a server side set value, while the index is just generated from the column order. I am not sure how/when they are different. Given the feedback on this change that the columns ids are not meant for public use, I will drop this change and instead follow up at a later time to remove the exposure of column ids in the PartitionSchema classes (which is where they are exposed). -- To view, visit http://gerrit.cloudera.org:8080/10546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee5c1abbe864b3e9f6905e0f70e9b708175071b0 Gerrit-Change-Number: 10546 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 01 Jun 2018 15:15:11 +0000 Gerrit-HasComments: No
