Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10547 )
Change subject: [Java] Add private API to get a table range partitions ...................................................................... Patch Set 1: (1 comment) As a side note, Impala has a todo to populate range splits. This API could be use to do that: https://github.com/apache/impala/blob/5c7d3b12e3aa750e7ab88e3ef1092d5218e53cc2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java#L304-L307 http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@259 PS1, Line 259: public List<Partition> getRangePartitions() throws Exception { > KuduScanTokenBuilder.build() performs RPCs, so the method ought to take a d By default the configured client operation timeout will be used. I didn't see why that wasn't sufficient. For example, in the existing getFormattedRangePartitions, Impala just passes the client configured value anyway: https://github.com/apache/impala/blob/5c7d3b12e3aa750e7ab88e3ef1092d5218e53cc2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java#L462-L463 https://github.com/apache/impala/blob/0c8eba076c10eecde578917e7f8ef78bba983fc4/fe/src/main/java/org/apache/impala/util/KuduUtil.java#L89-L90 When is there a case you wouldn't want to use the client configured timeout? -- To view, visit http://gerrit.cloudera.org:8080/10547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I612b93fbebc6f2f1c449bb3c7f2e561f1485a720 Gerrit-Change-Number: 10547 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 19:01:51 +0000 Gerrit-HasComments: Yes
