Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10547 )
Change subject: [Java] Add private API to get a table range partitions ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@230 PS1, Line 230: * @param deadline the deadline of the operation Nit: reading this again, this isn't actually a 'deadline' (a fixed point in time) but a 'timeout' (an amount of time). Can you rename it? http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@259 PS1, Line 259: public List<Partition> getRangePartitions() throws Exception { > By default the configured client operation timeout will be used. I didn't s Hmm, I assumed Impala was making use of the customized deadline. If not, perhaps it can be removed from getFormattedRangePartitions too? I'd ask Dan about this. -- To view, visit http://gerrit.cloudera.org:8080/10547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I612b93fbebc6f2f1c449bb3c7f2e561f1485a720 Gerrit-Change-Number: 10547 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 19:21:56 +0000 Gerrit-HasComments: Yes
