Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10547 )
Change subject: [Java] Add private API to get a table range partitions ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@230 PS1, Line 230: * @param deadline the deadline of the operation > Nit: reading this again, this isn't actually a 'deadline' (a fixed point in This is the way it is because all of the other methods in this file named it this. I do agree that it's more correctly a timeout, though. http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@259 PS1, Line 259: public List<Partition> getRangePartitions() throws Exception { > Hmm, I assumed Impala was making use of the customized deadline. If not, pe I'm weakly in favor of keeping a timeout arg on getFormattedRangePartitions (and adding it on the new method if necessary) for the following reasons: 1) It's kind of obnoxious to change the ABI of a method over such a small issue, regardless of whether it's Impala specific or not. 2) Other similar methods in this file take a timeout. 3) The change makes the method slightly less flexible. If I did it again I'd probably opt to not include it, though. http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java File java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java: http://gerrit.cloudera.org:8080/#/c/10547/1/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java@105 PS1, Line 105: public PartialRow getDecodedRangeKeyStart(KuduTable table) { Can these be default visibility? -- To view, visit http://gerrit.cloudera.org:8080/10547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I612b93fbebc6f2f1c449bb3c7f2e561f1485a720 Gerrit-Change-Number: 10547 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 21:15:17 +0000 Gerrit-HasComments: Yes
