Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10547 )
Change subject: [Java] Add private API to get a table range partitions ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10547/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/10547/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@248 PS2, Line 248: * If a null timeout is passed the default client operation timeout will be used. If the goal is to be consistent with getFormattedRangePartitions, I think this difference is weird and should be eliminated (i.e. use a lower-case long and force callers to provide the timeout). -- To view, visit http://gerrit.cloudera.org:8080/10547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I612b93fbebc6f2f1c449bb3c7f2e561f1485a720 Gerrit-Change-Number: 10547 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 18:36:29 +0000 Gerrit-HasComments: Yes
