Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10536 )
Change subject: [tools] add 'kudu tablet set_attributes' sub-command ...................................................................... Patch Set 2: (1 comment) I'll take over revving this since Alexey is away for a bit. Mike, would you mind reviewing? http://gerrit.cloudera.org:8080/#/c/10536/2/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/10536/2/src/kudu/tools/tool_action_tablet.cc@63 PS2, Line 63: DEFINE_bool(attribute_promote, false, : "The value for the tablet replicas's 'promote' attribute."); : DEFINE_bool(attribute_replace, false, : "The value for the tablet replicas's 'replace' attribute."); > We spoke offline about how it doesn't really make sense to set both of thes I changed my mind about this after thinking about how things will work if we add more attributes, and also after thinking about how to specify setting vs. unsetting a promote or replace attribute. -- To view, visit http://gerrit.cloudera.org:8080/10536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib304715100ba9062558863f140aa309fd604ace3 Gerrit-Change-Number: 10536 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 08 Jun 2018 21:17:26 +0000 Gerrit-HasComments: Yes
