Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10536 )
Change subject: [tools] add 'kudu tablet set_attributes' sub-command ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10536/3/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/10536/3/src/kudu/tools/tool_action_tablet.cc@254 PS3, Line 254: bool has_promote = !GetCommandLineFlagInfoOrDie("attribute_promote").is_default; > In the future we will likely add attributes. Will we always try to prevent OK, since it is not harmful to set both, I will remove this check. -- To view, visit http://gerrit.cloudera.org:8080/10536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib304715100ba9062558863f140aa309fd604ace3 Gerrit-Change-Number: 10536 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 20 Jun 2018 17:01:11 +0000 Gerrit-HasComments: Yes
