Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10536 )
Change subject: [tools] add 'kudu tablet set_attributes' sub-command ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10536/3/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/10536/3/src/kudu/tools/tool_action_tablet.cc@254 PS3, Line 254: return Status::InvalidArgument("cannot set both PROMOTE and REPLACE"); I agree it doesn't really make sense but what's the risk if we don't do this validation? http://gerrit.cloudera.org:8080/#/c/10536/3/src/kudu/tools/tool_action_tablet.cc@273 PS3, Line 273: change->mutable_peer()->mutable_attrs()->set_promote(promote); We may likely add additional attributes in the future, so I think if you don't specify a flag the tool should not attempt to set it or change its value. -- To view, visit http://gerrit.cloudera.org:8080/10536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib304715100ba9062558863f140aa309fd604ace3 Gerrit-Change-Number: 10536 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 11 Jun 2018 19:26:48 +0000 Gerrit-HasComments: Yes
